Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Authentication Method + Revamped Identity (Page) Workflow #2057

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

dangtony98
Copy link
Collaborator

@dangtony98 dangtony98 commented Jul 2, 2024

Description 📣

This PR contains (1) the implementation for a new Token Auth method and (2) a new Identity page (UI/UX redesign for working with identities).

Regarding Token Auth: This authentication method is meant to be the successor to Infisical's existing Service Token authentication method but built on top of identities. Instead of needing to obtain a Client ID / Secret pair and exchange it for an access token as part of Universal Auth, users can go ahead and create an access token directly on an identity if it has this authentication method attached.

Regarding the new Identity Page: We're moving to a new identities workflow where you can now manage everything for an identity on a separate page (instead of clicking on a bunch of icons in the identities table). By default, all newly-created identities in the UI have Universal Auth bound to them — this default will later be changed to Token Auth.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

@dangtony98 dangtony98 requested a review from maidul98 July 2, 2024 22:22
@dangtony98 dangtony98 marked this pull request as draft July 4, 2024 17:16
@dangtony98 dangtony98 marked this pull request as ready for review July 8, 2024 11:03
@dangtony98 dangtony98 changed the title Token Authentication Method Token Authentication Method + Revamped Identity (Page) Workflow Jul 8, 2024
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments here and there. LGTM otherwise (didn't review much of the frontend code but it seems to function well)

@dangtony98 dangtony98 merged commit 9bf358a into main Jul 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants