-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token Authentication Method + Revamped Identity (Page) Workflow #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments here and there. LGTM otherwise (didn't review much of the frontend code but it seems to function well)
...views/Org/MembersPage/components/OrgIdentityTab/components/IdentitySection/IdentityTable.tsx
Show resolved
Hide resolved
frontend/src/views/Org/IdentityPage/components/IdentityDetailsSection.tsx
Outdated
Show resolved
Hide resolved
backend/src/services/identity-access-token/identity-access-token-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-token-auth/identity-token-auth-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-token-auth/identity-token-auth-service.ts
Outdated
Show resolved
Hide resolved
...Org/MembersPage/components/OrgIdentityTab/components/IdentitySection/IdentityAwsAuthForm.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR contains (1) the implementation for a new Token Auth method and (2) a new Identity page (UI/UX redesign for working with identities).
Regarding Token Auth: This authentication method is meant to be the successor to Infisical's existing Service Token authentication method but built on top of identities. Instead of needing to obtain a Client ID / Secret pair and exchange it for an access token as part of Universal Auth, users can go ahead and create an access token directly on an identity if it has this authentication method attached.
Regarding the new Identity Page: We're moving to a new identities workflow where you can now manage everything for an identity on a separate page (instead of clicking on a bunch of icons in the identities table). By default, all newly-created identities in the UI have Universal Auth bound to them — this default will later be changed to Token Auth.
Type ✨